Repository navigation
Show the Filter dateline in the immersive layout - #16920
Open
peranosborn wants to merge 3 commits into
Open
peranosborn wants to merge 3 commits into
peranosborn wants to merge 3 commits into
Conversation
…yout Immersive articles in the revamped layout (StandardLayout) always got the slim nav. Articles tagged with a Filter series tag now get the full height masthead. Adds hasFilterSeriesTag to identify Filter content by its series tags. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Filter articles in the immersive layout now get the same TimeDateline as the standard layout, by passing webPublicationDate to ArticleMeta. hasFilterSeriesTag becomes hasFilterTag and now also matches the Filter commissioning desk tracking tags, so ArticleMeta and StandardLayout share one check for Filter content. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:7777acbcc41593ab6b8c1229dacff916da77e059c30577a4d63a5163f5b45f83"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-po-filter-immersive-dateline"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-32348"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGEFrom guardian/actions-ecr. |
peranosborn
requested review from
andrewHEguardian,
frederickobrien and
richcousins
October 12, 2026 17:09
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new component-level dateline selection lacks regression coverage.
1 open finding
What changed in this PR
Adds Filter-specific SEO datelines to immersive articles and centralizes Filter tag detection.
Changes:
- Supports series and commissioning-desk Filter tags.
- Passes publication dates through immersive metadata.
- Reuses Filter detection for datelines and navigation.
| File | Description |
|---|---|
src/lib/theFilter.ts |
Expands Filter tag detection. |
src/lib/theFilter.test.ts |
Tests supported Filter tags. |
src/layouts/StandardLayout.tsx |
Applies unified detection to navigation. |
src/layouts/ImmersiveLayout.tsx |
Supplies publication dates to article metadata. |
src/components/ArticleMeta.web.tsx |
Uses unified detection for SEO datelines. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
peranosborn
marked this pull request as ready for review
October 13, 2026 08:09
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
andrewHEguardian
approved these changes
Oct 13, 2026
andrewHEguardian
left a comment
andrewHEguardian
left a comment
Contributor
There was a problem hiding this comment.
Looks good, great to add tests 👍
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Updated the immersive layout to pass the webPublicationDate so the dataline can you the filter version for improved SEO for evergreen articles. Refactored the filter helper to support the commissioning desk tags for the filter.
Why?
Support the SEO freshness work for the filter.
How has this change been tested?